Extracted patches for users.py
Vratislav Podzimek
vpodzime at redhat.com
Mon Apr 7 11:01:46 UTC 2014
PATCH 1/2:
The contextlib module is imported but not used in the patch. I can
simply remove it before pushing, but I'm wondering if you tried to
create a contextmanager for forking+chroot and it didn't work or if you
didn't try it. It could be nice to use something like "with ForkedChild
as child:"
'import sys' should be done globally, not in the function.
PATCH 2/2 looks good to me.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches
mailing list