[PATCH] Don't confuse users by misleading tooltip (#1011112)

Vratislav Podzimek vpodzime at redhat.com
Tue Sep 24 21:03:19 UTC 2013


On Tue, 2013-09-24 at 16:49 -0400, Chris Lumens wrote:
> > diff --git a/widgets/src/LayoutIndicator.c b/widgets/src/LayoutIndicator.c
> > index c76768d..d77812b 100644
> > --- a/widgets/src/LayoutIndicator.c
> > +++ b/widgets/src/LayoutIndicator.c
> > @@ -28,7 +28,9 @@
> >  #include "LayoutIndicator.h"
> >  #include "intl.h"
> >  
> > -#define TOOLTIP_FORMAT_STR _("Current layout: '%s'. Click to switch to the next layout")
> > +#define TOOLTIP_BASE_FORMAT_STR _("Current layout: '%s'. %s")
> > +#define MULTIPLE_LAYOUTS_TIP  _("Click to switch to the next layout.")
> > +#define SINGLE_LAYOUT_TIP _("Add more layouts to enable switching.")
> >  #define DEFAULT_LAYOUT "us"
> >  #define DEFAULT_LABEL_MAX_CHAR_WIDTH 8
> >  #define MARKUP_FORMAT_STR "<span fgcolor='black' weight='bold'>%s</span>"
> 
> From a translation perspective, pasting the TOOLTIP_BASE_FORMAT_STR
> string together like this worries me.  It's a little better because you
> are using complete sentences, but I'm not convinced it'll work for
> everyone.  I don't suppose anyone else has experience with this?
I was thinking about having two macros with full tooltip format strings,
both starting with what the TOOLTIP_BASE_FORMAT_STR is. I guess that
would be better?

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list