[PATCH] Don't confuse users by misleading tooltip (#1011112)
Chris Lumens
clumens at redhat.com
Tue Sep 24 20:49:18 UTC 2013
> diff --git a/widgets/src/LayoutIndicator.c b/widgets/src/LayoutIndicator.c
> index c76768d..d77812b 100644
> --- a/widgets/src/LayoutIndicator.c
> +++ b/widgets/src/LayoutIndicator.c
> @@ -28,7 +28,9 @@
> #include "LayoutIndicator.h"
> #include "intl.h"
>
> -#define TOOLTIP_FORMAT_STR _("Current layout: '%s'. Click to switch to the next layout")
> +#define TOOLTIP_BASE_FORMAT_STR _("Current layout: '%s'. %s")
> +#define MULTIPLE_LAYOUTS_TIP _("Click to switch to the next layout.")
> +#define SINGLE_LAYOUT_TIP _("Add more layouts to enable switching.")
> #define DEFAULT_LAYOUT "us"
> #define DEFAULT_LABEL_MAX_CHAR_WIDTH 8
> #define MARKUP_FORMAT_STR "<span fgcolor='black' weight='bold'>%s</span>"
From a translation perspective, pasting the TOOLTIP_BASE_FORMAT_STR
string together like this worries me. It's a little better because you
are using complete sentences, but I'm not convinced it'll work for
everyone. I don't suppose anyone else has experience with this?
The code looks fine, though.
- Chris
More information about the anaconda-patches
mailing list