[lorax] [patch] tag fatal error as error
Vratislav Podzimek
vpodzime at redhat.com
Wed Sep 18 10:16:19 UTC 2013
On Tue, 2013-09-17 at 16:07 -0500, J_Groves at DELL.com wrote:
> Greetings,
>
>
>
> I’m new to pungi/lorax, but this suggestion addresses confusion for us
> in a complex build. To pungi, we pass a –ver <splat>. <splat> got
> too long, and lorax complained "the volume id cannot be longer than 32
> characters"
>
>
>
> Due to other cruft in our build log that included variants of the word
> “error”, we didn’t immediately realize this log entry was important.
>
>
>
> The following patch would address that confusion. (this is the only
> call to logger.fatal that I find in lorax)
>
>
>
> Best regards,
>
> John Groves
>
>
>
> ---
>
>
>
> diff --git a/src/pylorax/__init__.py b/src/pylorax/__init__.py
>
> index 37829da..e0ce0e0 100644
>
> --- a/src/pylorax/__init__.py
>
> +++ b/src/pylorax/__init__.py
>
> @@ -230,7 +230,7 @@ class Lorax(BaseLoraxClass):
>
>
> self.arch)
>
>
>
> if len(isolabel) > 32:
>
> - logger.fatal("the volume id cannot be longer than 32
> characters")
>
> + logger.fatal("ERROR: the volume id cannot be longer than
> 32 characters")
Are there so many fatal messages? If so, what about using
logger.critical instead of logger.fatal?
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches
mailing list