[lorax] [patch] tag fatal error as error

J_Groves at DELL.com J_Groves at DELL.com
Tue Sep 17 21:07:52 UTC 2013


Greetings,

I'm new to pungi/lorax, but this suggestion addresses confusion for us in a complex build.  To pungi, we pass a -ver <splat>.  <splat> got too long, and lorax complained "the volume id cannot be longer than 32 characters"

Due to other cruft in our build log that included variants of the word "error", we didn't immediately realize this log entry was important.

The following patch would address that confusion.  (this is the only call to logger.fatal that I find in lorax)

Best regards,
John Groves

---

diff --git a/src/pylorax/__init__.py b/src/pylorax/__init__.py
index 37829da..e0ce0e0 100644
--- a/src/pylorax/__init__.py
+++ b/src/pylorax/__init__.py
@@ -230,7 +230,7 @@ class Lorax(BaseLoraxClass):
                                                                        self.arch)

         if len(isolabel) > 32:
-            logger.fatal("the volume id cannot be longer than 32 characters")
+            logger.fatal("ERROR: the volume id cannot be longer than 32 characters")
             sys.exit(1)

         templatedir = self.conf.get("lorax", "sharedir")

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20130917/d213fee4/attachment.html>


More information about the anaconda-patches mailing list