[PATCH] Add storage tests.

David Shea dshea at redhat.com
Fri Oct 18 19:14:41 UTC 2013


On 10/17/2013 02:17 PM, Chris Lumens wrote:
> +    @property
> +    def expectedExceptionType(self):
> +        """Should this test component be expected to fail, this property returns
> +           the exception type.  If this component is expected to fail, this
> +           property returns None.  All components that are expected to fail
> +           should override this property.
> +        """
I think the second sentence here is supposed to "not expected to fail"
> diff --git a/tests/storage/cases/bz1014545.py b/tests/storage/cases/bz1014545.py
> new file mode 100644
> index 0000000..26e1f2e
> --- /dev/null
> +++ b/tests/storage/cases/bz1014545.py
> @@ -0,0 +1,110 @@
> +#!/usr/bin/python
> +#
> +# Copyright (C) 2013  Red Hat, Inc.
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU Lesser General Public License as published
> +# by the Free Software Foundation; either version 2.1 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU Lesser General Public License for more details.
> +#
> +# You should have received a copy of the GNU Lesser General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +#
> +# Author: Chris Lumens <clumens at redhat.com>
> +
> +# pylint: disable-msg=E0611
> +from . import TestCase, TestCaseComponent, create_sparse_file
Unused import create_sparse_file
> +    # This return code tells GNU make that this test was skipped.
> +    os._exit(77)
If you want to be precise here, and I'm sure you do, it's the automake 
test driver that checks for this return code.

Other than those little details, I like this. Ack.


More information about the anaconda-patches mailing list