[PATCH 3/4] Do not list PVs for preexisting VGs. (#1021274)

David Lehman dlehman at redhat.com
Tue Nov 19 16:17:01 UTC 2013


On Fri, 2013-11-15 at 17:38 -0800, Brian C. Lane wrote:
> On Fri, Nov 15, 2013 at 08:39:49AM -0600, David Lehman wrote:
> > ---
> >  blivet/devices.py | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/blivet/devices.py b/blivet/devices.py
> > index 2f85d64..93fc546 100644
> > --- a/blivet/devices.py
> > +++ b/blivet/devices.py
> > @@ -2490,7 +2490,11 @@ class LVMVolumeGroupDevice(DMDevice):
> >      def populateKSData(self, data):
> >          super(LVMVolumeGroupDevice, self).populateKSData(data)
> >          data.vgname = self.name
> > -        data.physvols = ["pv.%d" % p.id for p in self.parents]
> > +        if self.exists:
> > +            data.physvols = []
> > +        else:
> > +            data.physvols = ["pv.%d" % p.id for p in self.parents]
> > +
> >          data.preexist = self.exists
> >          if not self.exists:
> >              data.pesize = self.peSize * 1024
> > -- 
> > 1.8.1.4
> 
> Shouldn't we just comment them out so that the ks could be modified and
> used on a system w/o the same PV's?

Either way is fine with me, but I do think I should be fixing this in
pykickstart instead of in blivet. Consider this patch abandoned.



More information about the anaconda-patches mailing list