[PATCH 3/4] Do not list PVs for preexisting VGs. (#1021274)

Brian C. Lane bcl at redhat.com
Sat Nov 16 01:38:13 UTC 2013


On Fri, Nov 15, 2013 at 08:39:49AM -0600, David Lehman wrote:
> ---
>  blivet/devices.py | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/blivet/devices.py b/blivet/devices.py
> index 2f85d64..93fc546 100644
> --- a/blivet/devices.py
> +++ b/blivet/devices.py
> @@ -2490,7 +2490,11 @@ class LVMVolumeGroupDevice(DMDevice):
>      def populateKSData(self, data):
>          super(LVMVolumeGroupDevice, self).populateKSData(data)
>          data.vgname = self.name
> -        data.physvols = ["pv.%d" % p.id for p in self.parents]
> +        if self.exists:
> +            data.physvols = []
> +        else:
> +            data.physvols = ["pv.%d" % p.id for p in self.parents]
> +
>          data.preexist = self.exists
>          if not self.exists:
>              data.pesize = self.peSize * 1024
> -- 
> 1.8.1.4

Shouldn't we just comment them out so that the ks could be modified and
used on a system w/o the same PV's?

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list