[master 00/10] Addon Repo and .treeinfo support for Source Spoke

Brian C. Lane bcl at redhat.com
Thu Mar 14 21:36:32 UTC 2013


On Thu, Mar 14, 2013 at 05:03:42PM -0400, Chris Lumens wrote:
> Looking at:
> 
>     http://bcl.fedorapeople.org/images/addon-repo.png
> 
> These are the things that stick out to me:
> 
> (1) The left edge of the new repo stuff is not in line with the items
> under "Which installation source" and "Updates".

Ah, I see. I need to set the left margin to 12 like the others.

> 
> (2) The protocol entry doesn't act the same as the one for picking your
> installation source - that is, "http://" is duplicated.

That's a typo, you're supposed to just use the dropdown.

> 
> (3) The proxy entering information doesn't look the same as the one for
> picking your installation source - it's hidden behind a dalog up there,
> but always visible down below.

I thought it looked better like that since there is space for it and a
proxy button would just be hanging out by itself in that same space.

> 
> (4) We've now got a lot more widgets on this screen at all times, given
> that there's the display and editing of extra repos always visible.
> Does the editing need to be constantly visible?  Could it be a dialog?
> Or, could it somehow be combined into the display as well - make the
> name column user-editable, same for the URL.  Proxy might be a little
> tough here, unless the proxy info is the same for all addons.

I really don't want more dialogs. We could easily hide it under a [+]
disclosure: "[+] Additional Repositories"

Do you mean make the treeinfo entries directly editable? We'd also need
a column for mirror. I guess we could put a Proxy button into the list.
Probably best to see what Mizmo thinks.

> 
> (5) While I like getting rid of the DiskOverview for optical media (it
> never displayed right anyway), I don't like just having two labels there
> with the verify button.  It just doesn't stand out to me at all.

Yeah, that feels a bit too plain to me. Maybe some font or background
changes?

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20130314/4a540593/attachment.sig>


More information about the anaconda-patches mailing list