[master 00/10] Addon Repo and .treeinfo support for Source Spoke

Chris Lumens clumens at redhat.com
Thu Mar 14 21:03:42 UTC 2013


Looking at:

    http://bcl.fedorapeople.org/images/addon-repo.png

These are the things that stick out to me:

(1) The left edge of the new repo stuff is not in line with the items
under "Which installation source" and "Updates".

(2) The protocol entry doesn't act the same as the one for picking your
installation source - that is, "http://" is duplicated.

(3) The proxy entering information doesn't look the same as the one for
picking your installation source - it's hidden behind a dalog up there,
but always visible down below.

(4) We've now got a lot more widgets on this screen at all times, given
that there's the display and editing of extra repos always visible.
Does the editing need to be constantly visible?  Could it be a dialog?
Or, could it somehow be combined into the display as well - make the
name column user-editable, same for the URL.  Proxy might be a little
tough here, unless the proxy info is the same for all addons.

(5) While I like getting rid of the DiskOverview for optical media (it
never displayed right anyway), I don't like just having two labels there
with the verify button.  It just doesn't stand out to me at all.

- Chris


More information about the anaconda-patches mailing list