[blivet] add support for lvm thin provisioning

David Lehman dlehman at redhat.com
Wed Jun 26 16:49:31 UTC 2013


On Tue, 2013-06-25 at 20:51 -0700, Brian C. Lane wrote:
> On Tue, Jun 25, 2013 at 03:37:50PM -0500, David Lehman wrote:
> > This is a new thing that allows you to create a special type of
> > lv (thin pool) that acts as a container for another special type of
> > lv (thin lv). The thin provisioning part means the space for the thin
> > lvs is not actually allocated from the pool until it is used/written.
> > This means the pool does not necessarily have to have a size equal or
> > greater to the sum of the sizes of the thin lvs it contains.
> > 
> > There are some more detailed comments in both the commit messages and
> > the code itself.
> > 
> > I am only proposing this for master -- not for f19.
> 
> These all look pretty good to me. I only came up with 2 comments, about
> 10/10
> 
> 1. In a couple places you use if x in [a, b, c] that could use tuples
> instead of lists (I think we're trying to standardize on using tuples
> for those now).

That's fine with me. I was using tuples until recently, when I somehow
got the impression I should be using lists instead. I'll change it.

> 
> 2. In self._pesize the docstring says it could return None, I'm not sure
> if that can actually happen but if it does the calls to get_pool_padding
> will blow up.

I changed it to fall back to the default extent size without updating
the docstring. I've updated the comment in my local tree.

> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches




More information about the anaconda-patches mailing list