[blivet] add support for lvm thin provisioning

Brian C. Lane bcl at redhat.com
Wed Jun 26 03:51:23 UTC 2013


On Tue, Jun 25, 2013 at 03:37:50PM -0500, David Lehman wrote:
> This is a new thing that allows you to create a special type of
> lv (thin pool) that acts as a container for another special type of
> lv (thin lv). The thin provisioning part means the space for the thin
> lvs is not actually allocated from the pool until it is used/written.
> This means the pool does not necessarily have to have a size equal or
> greater to the sum of the sizes of the thin lvs it contains.
> 
> There are some more detailed comments in both the commit messages and
> the code itself.
> 
> I am only proposing this for master -- not for f19.

These all look pretty good to me. I only came up with 2 comments, about
10/10

1. In a couple places you use if x in [a, b, c] that could use tuples
instead of lists (I think we're trying to standardize on using tuples
for those now).

2. In self._pesize the docstring says it could return None, I'm not sure
if that can actually happen but if it does the calls to get_pool_padding
will blow up.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20130625/4bc81e3c/attachment.sig>


More information about the anaconda-patches mailing list