[anaconda][PATCH] Allow hubs and standalone spokes decide if it is possible to continue

Vratislav Podzimek vpodzime at redhat.com
Tue Jun 18 08:13:17 UTC 2013


On Mon, 2013-06-17 at 15:18 -0400, Chris Lumens wrote:
> > +    def _register_continue_event_cb(self, cb):
> > +        """Registers the callback for the continue event adding the check."""
> > +
> > +        self.continueButton.connect("clicked", lambda *args: self._checked_continue(cb))
> >  
> >      def register_event_cb(self, event, cb):
> >          if event == "continue" and hasattr(self, "continueButton"):
> > -            self.continueButton.connect("clicked", lambda *args: cb())
> > +            self._register_continue_event_cb(cb)
> >          elif event == "quit" and hasattr(self, "quitButton"):
> >              self.quitButton.connect("clicked", lambda *args: cb())
> 
> I find this part weird.  Basically how it looks to me is like there's a
> chance for the continue button to be clickable, but if you click it then
> you cannot continue.  We're currently controlling the sensitivity of the
> continue button so it's only clickable if you are allowed to continue.
> I don't really like tricking the user like this.
Well, the continue button is not sensitive when some mandatory spokes
are not finished. But to warn user that something might be wrong and
require confirmation, we use that 'double-click' policy. So in case of
the Initial Setup if no user is created, the spokes are completed, but
we want to warn the user that no user account was created. One way is to
popup a dialog, the other way is to require them click once more on the
continue button. Shall I go the "dialog way" instead? I cannot make the
continue button insensitive, because continuing with no user created is
a valid use case.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list