[PATCH] Use the new Fedora GeoIP API (#963531)

Martin Kolman mkolman at redhat.com
Wed Jun 5 10:50:42 UTC 2013


Vratislav Podzimek píše v St 05. 06. 2013 v 11:36 +0200:
> On Tue, 2013-06-04 at 17:10 -0400, Chris Lumens wrote:
> > > @@ -343,6 +375,10 @@ class LocationResult(object):
> > >      def __str__(self):
> > >          if self.territory_code:
> > >              result_string = "territory: %s" % self.territory_code
> > > +            if self.timezone:
> > > +                result_string += "\ntime zone: %s (from %s)" % (
> > > +                    self.timezone, self._timezone_source
> > > +                )
> > >              if self.public_ip_address:
> > >                  result_string += "\npublic IP address: "
> > >                  result_string += "%s" % self.public_ip_address
> > 
> > Does this string ever get translated before being displayed?  If so,
> > it's going to be awful difficult to translate in its current form.
> Agreed, but I believe this is used/useful only for logging, right?
> Otherwise this looks good to me, we just need to wait for the service
> and its API to settle down.
> 
Yes, it is only used for logging (so that potential issues with the API
returning incorrect data for a given location could be debugged).



More information about the anaconda-patches mailing list