[PATCH] Use the new Fedora GeoIP API (#963531)

Vratislav Podzimek vpodzime at redhat.com
Wed Jun 5 09:36:41 UTC 2013


On Tue, 2013-06-04 at 17:10 -0400, Chris Lumens wrote:
> > @@ -343,6 +375,10 @@ class LocationResult(object):
> >      def __str__(self):
> >          if self.territory_code:
> >              result_string = "territory: %s" % self.territory_code
> > +            if self.timezone:
> > +                result_string += "\ntime zone: %s (from %s)" % (
> > +                    self.timezone, self._timezone_source
> > +                )
> >              if self.public_ip_address:
> >                  result_string += "\npublic IP address: "
> >                  result_string += "%s" % self.public_ip_address
> 
> Does this string ever get translated before being displayed?  If so,
> it's going to be awful difficult to translate in its current form.
Agreed, but I believe this is used/useful only for logging, right?
Otherwise this looks good to me, we just need to wait for the service
and its API to settle down.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list