[PATCH] Make the Welcome spoke wait for Geolocation lookup to finish (#975193)

Martin Kolman mkolman at redhat.com
Thu Jul 4 11:39:25 UTC 2013


On Wed, 2013-07-03 at 09:07 -0400, Chris Lumens wrote:
> > The GeoIP lookup usually takes between 1 to 2 seconds to finish.
> > In some cases, such as when running on a live system, the welcome spoke
> > might show up before the lookup can finish, so the result of the lookup
> > can not be used to pre-set the language.
> > 
> > To improve this, the geoloc module top level functions now have an
> > optional wait parameter, that makes the function block until the
> > lookup is is done or a timeout is reached.
> > 
> > The end result is, that the Welcome spoke will wait up to 3 seconds
> > for the lookup to finish. Usually it would wait less than 2 seconds or
> > not at all (if the lookup finishes before the welcome spoke is even
> > initialized).
> 
> I think I am okay with adding an extra pause here.  How does it feel to
> you having tested it? Does the spinning cursor still show up fairly
> quickly? 
Seemed to work fine when I tested it, not sure about the spinning cursor
though.
> If so, that will help to make it not seem like so long of a
> pause up front.  Would it perhaps be possible to move the start of this
> earlier in anaconda?
It's currently started right in the beginning, just after network
initialization and storage/time/payload threads are started. It waits
for network to initialize and does the GeoIP refresh once connectivity
becomes available. I don't think it can be started any earlier, due to
the need for an initialized network connection.

> 
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
Martin



More information about the anaconda-patches mailing list