[PATCH] Make the Welcome spoke wait for Geolocation lookup to finish (#975193)

Chris Lumens clumens at redhat.com
Wed Jul 3 13:07:26 UTC 2013


> The GeoIP lookup usually takes between 1 to 2 seconds to finish.
> In some cases, such as when running on a live system, the welcome spoke
> might show up before the lookup can finish, so the result of the lookup
> can not be used to pre-set the language.
> 
> To improve this, the geoloc module top level functions now have an
> optional wait parameter, that makes the function block until the
> lookup is is done or a timeout is reached.
> 
> The end result is, that the Welcome spoke will wait up to 3 seconds
> for the lookup to finish. Usually it would wait less than 2 seconds or
> not at all (if the lookup finishes before the welcome spoke is even
> initialized).

I think I am okay with adding an extra pause here.  How does it feel to
you having tested it?  Does the spinning cursor still show up fairly
quickly?  If so, that will help to make it not seem like so long of a
pause up front.  Would it perhaps be possible to move the start of this
earlier in anaconda?

- Chris


More information about the anaconda-patches mailing list