[blivet master 5/5] Mark all format names as translatable

Vratislav Podzimek vpodzime at redhat.com
Tue Dec 10 06:58:22 UTC 2013


On Mon, 2013-12-09 at 13:28 -0800, Brian C. Lane wrote:
> On Fri, Dec 06, 2013 at 09:50:06AM -0500, David Shea wrote:
> 
> > I think the first idea is the better one. We can leave the formats
> > themselves marked with N_ in blivet and revert the change to
> > DeviceFormat.name so that property remains untranslated. The
> > translations will exist in blivet, but will not be used by blivet.
> > In the anaconda storage spokes, do something like `from blivet.i18n
> > import _ as B_' and use B_ around any place where we treat
> > DeviceFormat.name as a string to display and not as an identifier.
> > 
> > Thoughts?
> 
> I like #1 as well, although I think blivet should also have a translated
> version it makes available instead of anaconda (or any other blivet
> users) needing to do their own import of blivet.i18n
What about something like get_name(xlated=False)? I know properties are
nice, but sometimes having a good old method instead works better.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list