[PATCH rhel7-branch] text network spoke

Radek Vykydal rvykydal at redhat.com
Tue Aug 27 13:04:46 UTC 2013


On 08/26/2013 08:47 PM, Brian C. Lane wrote:
> On Thu, Aug 22, 2013 at 03:20:09PM +0200, Radek Vykydal wrote:
>> Video:
>> http://rvykydal.fedorapeople.org/textnetwork.webm
> This is looking pretty nice, some general comments:
>   * The "Network Setting" summary is going to scroll off the top with
>     systems that have more than 2 nics. I think we should take advantage
>     of the 80 column width and try to use less height for the status of
>     each nic.

Yes, Samantha had similar remark in her review.
Addressed in [2/4] on the new text network patchset I've just sent.

>   * New methods should all have docstrings using the Sphinx style that
>     we've been slowly adopting.

I'm going to fix this in the whole nm.py.

>   * the new network.py file needs to be added to po/POTFILES.in

[4/4] of the new patchset.

>
> We also need input validation on the network values, either in the UI or
> at a lower level so that we don't get tracebacks when entering invalid
> IP addresses, or leaving things like the gateway blank.

[3/4] of the new patchset. (Plus the tui Entry regexp checks already in 
and waiting
for review for ipv6)


Thanks for the review,

Radek


More information about the anaconda-patches mailing list