[PATCH rhel7-branch] text network spoke

Brian C. Lane bcl at redhat.com
Mon Aug 26 18:47:04 UTC 2013


On Thu, Aug 22, 2013 at 03:20:09PM +0200, Radek Vykydal wrote:
> Video:
> http://rvykydal.fedorapeople.org/textnetwork.webm

This is looking pretty nice, some general comments:
 * The "Network Setting" summary is going to scroll off the top with
   systems that have more than 2 nics. I think we should take advantage
   of the 80 column width and try to use less height for the status of
   each nic.
 * New methods should all have docstrings using the Sphinx style that
   we've been slowly adopting.
 * the new network.py file needs to be added to po/POTFILES.in

We also need input validation on the network values, either in the UI or
at a lower level so that we don't get tracebacks when entering invalid
IP addresses, or leaving things like the gateway blank.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20130826/8023d4fc/attachment.sig>


More information about the anaconda-patches mailing list