[PATCH 1/3] Set timeout=0 option in /etc/crypttab by default. (#949702)
Chris Lumens
clumens at redhat.com
Thu Apr 11 18:53:56 UTC 2013
> > diff --git a/blivet/formats/luks.py b/blivet/formats/luks.py
> > index ab12eba..902b326 100644
> > --- a/blivet/formats/luks.py
> > +++ b/blivet/formats/luks.py
> > @@ -80,6 +80,12 @@ class LUKS(DeviceFormat):
> > # default to the max (512 bits) for aes-xts
> > self.key_size = 512
> >
> > + # default to no timeout when prompting for a passphrase (post-install)
> > + if self.options is None:
> > + self.options = "timeout=0"
> > + elif "timeout=" not in self.options:
> > + self.options += ",timeout=0"
> > +
>
> I'm curious: If this is the default, why isn't it the upstream default?
>
> A comment referencing the bug (or upstream's reasoning for why this
> isn't the default) would probably be a really good idea.
>
> Otherwise we'll someday end up with junior anaconda maintainers trying
> to contact our island fortresses / mountaintop lairs to ask us why
> anaconda needed to do this and whether they can remove it..
I am additionally curious how this differs from the following code,
already in __init__.py:
if device.encrypted:
options += ",x-systemd.device-timeout=0"
Why do we need two, differently named, options in two different places?
- Chris
More information about the anaconda-patches
mailing list