[PATCH 1/3] Set timeout=0 option in /etc/crypttab by default. (#949702)

Will Woods wwoods at redhat.com
Tue Apr 9 18:19:04 UTC 2013


I don't object to the patch itself, but...

On Tue, 2013-04-09 at 12:57 -0500, David Lehman wrote:
> ---
>  blivet/formats/luks.py | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/blivet/formats/luks.py b/blivet/formats/luks.py
> index ab12eba..902b326 100644
> --- a/blivet/formats/luks.py
> +++ b/blivet/formats/luks.py
> @@ -80,6 +80,12 @@ class LUKS(DeviceFormat):
>                  # default to the max (512 bits) for aes-xts
>                  self.key_size = 512
>  
> +        # default to no timeout when prompting for a passphrase (post-install)
> +        if self.options is None:
> +            self.options = "timeout=0"
> +        elif "timeout=" not in self.options:
> +            self.options += ",timeout=0"
> +

I'm curious: If this is the default, why isn't it the upstream default? 

A comment referencing the bug (or upstream's reasoning for why this
isn't the default) would probably be a really good idea.

Otherwise we'll someday end up with junior anaconda maintainers trying
to contact our island fortresses / mountaintop lairs to ask us why
anaconda needed to do this and whether they can remove it..

-w



More information about the anaconda-patches mailing list