[PATCH 1/5] Validate mountpoints in the add-a-mountpoint dialog.

David Lehman dlehman at redhat.com
Fri Sep 7 15:15:20 UTC 2012


On Fri, 2012-09-07 at 11:13 -0400, Chris Lumens wrote:
> > @@ -132,9 +138,33 @@ class AddDialog(GUIObject):
> >          completion.set_text_column(0)
> >          completion.set_popup_completion(True)
> >  
> > +    def on_text_changed(self, entry):
> 
> How often is this going to fire?  Every time a character is typed?

Yes.

> 
> > +        mountpoint = self.builder.get_object("addMountPointEntry").get_text()
> > +        warning_label = self.builder.get_object("mountPointWarningLabel")
> > +        if mountpoint in self.mountpoints:
> > +            warning_label.set_text(self.mountpoint_in_use_msg)
> > +            self._warningBox.show_all()
> > +            sensitive = False
> > +        elif not mountpoint:
> > +            self._warningBox.hide()
> > +            sensitive = False
> > +        elif (mountpoint.lower() not in ("swap", "biosboot", "prepboot") and
> 
> I'm still concerned that these last two will not be discoverable.
> Perhaps also add them to the mountPointStore?

Good idea.

> 
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches




More information about the anaconda-patches mailing list