[PATCH 1/5] Validate mountpoints in the add-a-mountpoint dialog.

Chris Lumens clumens at redhat.com
Fri Sep 7 15:13:52 UTC 2012


> @@ -132,9 +138,33 @@ class AddDialog(GUIObject):
>          completion.set_text_column(0)
>          completion.set_popup_completion(True)
>  
> +    def on_text_changed(self, entry):

How often is this going to fire?  Every time a character is typed?

> +        mountpoint = self.builder.get_object("addMountPointEntry").get_text()
> +        warning_label = self.builder.get_object("mountPointWarningLabel")
> +        if mountpoint in self.mountpoints:
> +            warning_label.set_text(self.mountpoint_in_use_msg)
> +            self._warningBox.show_all()
> +            sensitive = False
> +        elif not mountpoint:
> +            self._warningBox.hide()
> +            sensitive = False
> +        elif (mountpoint.lower() not in ("swap", "biosboot", "prepboot") and

I'm still concerned that these last two will not be discoverable.
Perhaps also add them to the mountPointStore?

- Chris


More information about the anaconda-patches mailing list