[PATCH anaconda/master] Add very basic U-Boot support for ARM platforms.

David Marlin dmarlin at redhat.com
Tue Nov 6 23:47:53 UTC 2012


Brian C. Lane wrote:
> On Fri, Nov 02, 2012 at 06:59:21PM -0500, d.marlin wrote:
>> +    def write_config_images(self, config):
>> +        for image in self.images:
>> +            log.info("bootloader.py: write dummy config stanza.")
>> +            stanza = (" ")
>> +            config.write(stanza)
> 
> Does this really need to do anything? All you're doing is writing some
> spaces. To avoid the NotImplementedError you could just make this a
> pass. Also, if it is needed, logging the same string each time through
> the loop isn't very helpful. It should include details about the image.

Currently we are providing an empty boot.scr file in grubby, which is 
not the correct place to do it, but it has served the need until now. 
The kernel install (using grubby) checks for the existence of this file 
to know if U-Boot images should be created.  The contents (at this 
point) are not important.  I may be thinking incorrectly.  Will this 
bootloader code be performed before the kernel is installed?  If not, 
there is no need to write a boot.scr here.

Regardless, the actual contents of boot.scr will be replaced in the 
%post section of the kickstart file for each type system.  We are 
handling that in the kickstart files because there are so many different 
U-Boot scripts and options used it would not be practical to try and put 
them all in bootloader.py (or maintain them there).

The logging was really for debugging purposes.  I will remove it.

> 
>> +
>> +    #
>> +    # installation
>> +    #
>> +    def write_config(self):
>> +        log.info("bootloader.py: write config.")
>> +        super(UBOOT, self).write_config()
> 
> You don't need to override this unless it is going to add something to
> the superclass' version.

Again, this was more for debugging (logging to verify the path it was 
taking).  I will remove it.


I am doing some additional testing of this patch now.  If successful, I 
will submit an updated version of the patch incorporating all your 
suggestions.

Thank you for reviewing this, and for your suggestions.


d.marlin
==========

> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches


More information about the anaconda-patches mailing list