[PATCH anaconda/master] Add very basic U-Boot support for ARM platforms.

Brian C. Lane bcl at redhat.com
Tue Nov 6 18:54:39 UTC 2012


On Fri, Nov 02, 2012 at 06:59:21PM -0500, d.marlin wrote:
> +    def write_config_images(self, config):
> +        for image in self.images:
> +            log.info("bootloader.py: write dummy config stanza.")
> +            stanza = (" ")
> +            config.write(stanza)

Does this really need to do anything? All you're doing is writing some
spaces. To avoid the NotImplementedError you could just make this a
pass. Also, if it is needed, logging the same string each time through
the loop isn't very helpful. It should include details about the image.


> +
> +    #
> +    # installation
> +    #
> +    def write_config(self):
> +        log.info("bootloader.py: write config.")
> +        super(UBOOT, self).write_config()

You don't need to override this unless it is going to add something to
the superclass' version.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 478 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20121106/b493b20a/attachment.sig>


More information about the anaconda-patches mailing list