[PATCH 4/4] Run a storage sanity check when leaving the storage spoke.

David Lehman dlehman at redhat.com
Tue Jul 10 18:59:52 UTC 2012


On Tue, 2012-07-10 at 12:52 -0400, Chris Lumens wrote:
> > @@ -320,10 +345,12 @@ class StorageSpoke(NormalSpoke):
> >                       ("%d disks selected"),
> >                       len(self.data.ignoredisk.onlyuse)) % len(self.data.ignoredisk.onlyuse)
> >  
> > -            if self.data.autopart.autopart:
> > +            if self.errors:
> > +                msg = _("Error checking storage configuration")
> > +            elif self.data.autopart.autopart:
> >                  msg = _("Automatic partitioning selected")
> > -
> > -                # if we had a storage instance we could check for a defined root
> > +            else:
> > +                msg = _("Custom partitioning selected")
> >  
> >          return msg
> 
> I notice you don't do anything with self.warnings in this chunk, which
> seems like a reasonable place to do something with it.

Yeah, for two reasons (neither very good). First, I had been throwing
out the warnings, but decided at the last minute to start saving them
for whenever we have a way to show them to the user. Second, I am
struggling to find good phrasing for the corresponding status message.
"Error checking storage configuration" seems perfectly clear to me, yet
"Warning checking storage configuration" does not. Ideas?

Dave

> 
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/anaconda-patches




More information about the anaconda-patches mailing list