[PATCH 4/4] Run a storage sanity check when leaving the storage spoke.

Chris Lumens clumens at redhat.com
Tue Jul 10 16:52:37 UTC 2012


> @@ -320,10 +345,12 @@ class StorageSpoke(NormalSpoke):
>                       ("%d disks selected"),
>                       len(self.data.ignoredisk.onlyuse)) % len(self.data.ignoredisk.onlyuse)
>  
> -            if self.data.autopart.autopart:
> +            if self.errors:
> +                msg = _("Error checking storage configuration")
> +            elif self.data.autopart.autopart:
>                  msg = _("Automatic partitioning selected")
> -
> -                # if we had a storage instance we could check for a defined root
> +            else:
> +                msg = _("Custom partitioning selected")
>  
>          return msg

I notice you don't do anything with self.warnings in this chunk, which
seems like a reasonable place to do something with it.

- Chris


More information about the anaconda-patches mailing list