[PATCH conductor] Update travis-ci config file to match new bundler usage changes in RM 3455

John Eckersberg jeckersb at redhat.com
Wed Jul 25 17:45:29 UTC 2012


Richard Su <rwsu at redhat.com> writes:

> https://www.aeolusproject.org/redmine/issues/3455
>
> 1. Use Gemfile instead of Gemfile.in.
> 2. Remove USE_BUNDLER environment variable.
> 3. Add "--path bundle" to "bundle install"
> 4. "bundle exec" all rake commands. Not doing so would produce this error:
>
> "You have already activated rake 0.9.2, but your Gemfile requires rake 0.9.2.2.
> Using bundle exec may solve this."
> ---
>  .travis.yml |   20 ++++++++++----------
>  1 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index d2cdb85..89760fa 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -7,21 +7,21 @@ env:
>    - SUITE=cucumber
>    - SUITE=spec
>  before_install:
> -  - sed s/'pg'/'sqlite3'/ src/Gemfile.in > src/Gemfile
> +  - sed s/'pg'/'sqlite3'/ src/Gemfile > src/Gemfile.tmp
> +  - mv src/Gemfile.tmp src/Gemfile
>  install:
>    - cd src 
> -  - bundle install
> +  - bundle install --path bundle
>  before_script:
> -  - export USE_BUNDLER=yes
>    - cp config/database.sqlite config/database.yml
> -  - rake dc:oauth_keys
> -  - rake db:drop
> -  - rake db:create
> -  - rake db:migrate
> -  - rake db:seed
> -  - rake db:test:prepare
> +  - bundle exec rake dc:oauth_keys
> +  - bundle exec rake db:drop
> +  - bundle exec rake db:create
> +  - bundle exec rake db:migrate
> +  - bundle exec rake db:seed
> +  - bundle exec rake db:test:prepare
>  script:
> -  - rake $SUITE
> +  - bundle exec rake $SUITE
>  notifications:
>    irc:
>      channels:
> -- 
> 1.7.7.6

This looks pretty good to me.  I don't really know how to test it
besides pushing it to master and seeing how travis reacts to the new
change.

One nit, instead of:

  - sed s/'pg'/'sqlite3'/ src/Gemfile > src/Gemfile.tmp
  - mv src/Gemfile.tmp src/Gemfile

just do:

  - sed -i s/'pg'/'sqlite3'/ src/Gemfile

Beyond that, I say +1 to pushing it and seeing what happens.



More information about the aeolus-devel mailing list