[PATCH] BZ 790548 add spacing if there are multiple target image uuids

Matt Wagner matt.wagner at redhat.com
Wed Feb 15 01:38:59 UTC 2012


On Tue, Feb 14, 2012 at 05:29:46PM -0500, Tzu-Mainn Chen wrote:
> ---
>  src/app/views/deployables/_image_uuids.html.haml |   32 +++++++++++++++------
>  1 files changed, 23 insertions(+), 9 deletions(-)
> 
> diff --git a/src/app/views/deployables/_image_uuids.html.haml b/src/app/views/deployables/_image_uuids.html.haml
> index 9ee8972..91902a2 100644
> --- a/src/app/views/deployables/_image_uuids.html.haml
> +++ b/src/app/views/deployables/_image_uuids.html.haml
> @@ -1,9 +1,23 @@
> -%li
> -  %strong="#{t("deployables.show.image_uuid")}"
> -  ="#{(@images_hash_details[index][0].nil? ? t('deployables.show.n_a') : @images_hash_details[index][0])}"
> -%li
> -  %strong="#{t("deployables.show.latest_build_uuid")}"
> -  ="#{(@images_hash_details[index][1].nil? ? t("deployables.show.n_a") : @images_hash_details[index][1])}"
> -%li
> -  %strong="#{t("deployables.show.target_images_uuids")}"
> -  ="#{(@images_hash_details[index][2].nil? ? t("deployables.show.n_a") : @images_hash_details[index][2])}"
> \ No newline at end of file
> +%table.light_table
> +  %tbody
> +    %tr
> +      %td
> +        %strong="#{t("deployables.show.image_uuid")}"
> +      %td
> +        ="#{(@images_hash_details[index][0].nil? ? t('deployables.show.n_a') : @images_hash_details[index][0])}"
> +    %tr
> +      %td
> +        %strong="#{t("deployables.show.latest_build_uuid")}"
> +      %td
> +        ="#{(@images_hash_details[index][1].nil? ? t("deployables.show.n_a") : @images_hash_details[index][1])}"
> +    %tr
> +      %td
> +        %strong="#{t("deployables.show.target_images_uuids")}"
> +      %td
> +        - if @images_hash_details[index][2].nil?
> +          =t'deployables.show.n_a'
> +        - else
> +          %ul
> +            - @images_hash_details[index][2].each do |image_uuid|
> +              %li
> +                =image_uuid
> -- 

ACK, with a bonus high-five for not just fixing the bug itself, but for
de-uglifying in the process.

-- Matt



More information about the aeolus-devel mailing list