From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: stop using hard coded values for heartbeats
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/78293/3/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm/jsonrpcvdscli.py:
Line 214: self._client.close()
Line 215:
Line 216:
Line 217: def _create(requestQueue, host=None, port=None, useSSL=None,
Line 218: responseQueue=None, incoming_heartbeat=5000, outgoing_heartbeat=0):
do we want the default to be configurable?.. maybe mention the default in the commit msg
Line 219: if host is None:
Line 220: host = 'localhost'
Line 221: if port is None:
Line 222: port = int(config.getint('addresses',
'management_port'))
--
To view, visit
https://gerrit.ovirt.org/78293
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cfec389e9d24d70e64617471df0d1dceb4229f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes