From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: api: adding context for api calls
......................................................................
Patch Set 5: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/75335/5/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 21:
Line 22: from vdsm.compat import json
Line 23:
Line 24: from vdsm.common import exception
Line 25: from vdsm.common.threadlocal import vars
I would import it as theadlocal. using threadlocal.vars is more readable
Line 26: from vdsm.logUtils import Suppressed
Line 27: from vdsm.password import protect_passwords, unprotect_passwords
Line 28: from vdsm.utils import monotonic_time, traceback
Line 29:
Line 632:
Line 633: self._parseMessage(obj)
Line 634:
Line 635: def _parseMessage(self, obj):
Line 636: client, server_address, context, msg = obj
context is the new header? if so, why the header is called only ovirt collection id if it
includes also origin address?
Line 637: ctx = _JsonRpcServeRequestContext(client, server_address, context)
Line 638:
Line 639: try:
Line 640: rawRequests = json.loads(msg)
https://gerrit.ovirt.org/#/c/75335/5/tests/stompadapter_test.py
File tests/stompadapter_test.py:
Line 1: #
Line 2: # Copyright 2015 Red Hat, Inc.
dates
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
--
To view, visit
https://gerrit.ovirt.org/75335
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e73edc929e6d3e55d3f33a51229180ba35c52ac
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes