From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: common: move thread local
......................................................................
Patch Set 2: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/75516/2//COMMIT_MSG
Commit Message:
Line 6:
Line 7: common: move thread local
Line 8:
Line 9: The module is useful and can be used outside of storage so moving it to
Line 10: common.
I think better to say - we want to use the module in ** , so moving it out of storage
package to common
Line 11:
Line 12:
Line 13: Change-Id: If041a1ce38087d209258dc1a7661161f8f65c03c
https://gerrit.ovirt.org/#/c/75516/2/lib/vdsm/common/threadlocal.py
File lib/vdsm/common/threadlocal.py:
Line 1: #
Line 2: # Copyright 2011-2016 Red Hat, Inc.
dates
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
Line 22:
Line 23: import threading
Line 24:
Line 25: vars = threading.local()
Line 26: vars.task = None
if we make it an infra - can you add here a comment why we put in vars.task None always
when we use this module? its not documented now because its probably related only to
"storage tasks"
--
To view, visit
https://gerrit.ovirt.org/75516
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If041a1ce38087d209258dc1a7661161f8f65c03c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes