Saggi Mizrahi has posted comments on this change.
Change subject: Move domain monitor out of sp.py
......................................................................
Patch Set 19: (1 inline comment)
....................................................
File vdsm/storage/domainMonitor.py
Line 29: "vgMdFreeBelowThreashold")
Because it will be used mostly for consumption outside the module I think it's a
convenient way to know what fields return from domainMonitorStatus. Just trying this
coding paradigm out seeing if I like it. It can't hurt and you can remove it at any
time.
--
To view, visit
http://gerrit.ovirt.org/190
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ilvovsky(a)gmail.com