Dan Kenigsberg has posted comments on this change.
Change subject: Move domain monitor out of sp.py
......................................................................
Patch Set 19: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/domainMonitor.py
Line 29: "vgMdFreeBelowThreashold")
I wouldn't have bothered with __slots__ - we do not plan for 1000s SDs for the size to
matter.
Or is there a hidden cause for this?
....................................................
File vdsm/storage/hsm.py
Line 2580: # Stop repoStat threads
are you sure this code works?
I'd expect self.pools.values() here.
--
To view, visit
http://gerrit.ovirt.org/190
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ilvovsky(a)gmail.com