Nir Soffer has posted comments on this change.
Change subject: XXX: Insert sleep when creating block SD
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/43553/1/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 898:
Line 899: # XXX: When running an iSCSI server and initiator on the same host we
Line 900: # need to wait a bit for IO to settle before deactivating LVs
Line 901: import time
Line 902: time.sleep(10)
This is not a real solution. Maybe you want to use sync() instead?
Line 903: lvm.deactivateLVs(vgName, MASTERLV)
Line 904:
Line 905: path = lvm.lvPath(vgName, sd.METADATA)
Line 906:
--
To view, visit
https://gerrit.ovirt.org/43553
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ed63d747f1353da824af8ec56ac8a6f66d666b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes