Dan Kenigsberg has posted comments on this change.
Change subject: Add "devcapacity" to PV info
......................................................................
Patch Set 2: I would prefer that you didn't submit this
I believe that Eduardo has a good point: getVGInfo supplies lvm-related info. The device
capacity is accessible by getDeviceInfo, and the the correlation between the two should be
done using the GUID of the LUN, not using its size. We have a noble tendency to make life
easier on rhevm, but here we are making our API ever so slightly uglier.
--
To view, visit
http://gerrit.usersys.redhat.com/734
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0bd3c94a6e4999cb91f96c798a0108890321fbd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>