Federico Simoncelli has posted comments on this change.
Change subject: getStorageDomainInfo: SP keys when disconnected.
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
....................................................
Commit Message
Line 12: directly the pool MD for any MSD.
Line 13: This changes the previous behaviour.
Line 14:
Line 15: TODO: pool related information should not be returned as part of
Line 16: this API response.
I also prefer to return the pool-related info only on the connected pool master. It seems
easier, it would respect the current api and it would prevent the use of StoragePool
internals from hsm.py.
Line 17:
Line 18: Change-Id: I8b7323d4ccaaaec0f39d5590a06879faa7fc999e
--
To view, visit
http://gerrit.ovirt.org/19555
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b7323d4ccaaaec0f39d5590a06879faa7fc999e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Aharon Canan <aharonca(a)gmail.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Gadi Ickowicz <gickowic(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes