Yaniv Bronhaim has posted comments on this change.
Change subject: Adding removeConf to sanlock module
......................................................................
Patch Set 6:
(1 comment)
did you test configure sanlock module on ovirt node? where do we persist /etc/groups after
the spec configure call that you added?
http://gerrit.ovirt.org/#/c/26055/6/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 639: raw=True,
Line 640: )
Line 641: sys.stdout.write(out)
Line 642: sys.stderr.write(err)
Line 643:
What about include: if isOvirt: persist /etc/group
we need to
add it both here and in configure as you said. please post a patch for that and rebase it
on this one (I don't familiar with the node semantics enough)
Line 644: if rc != 0:
Line 645: raise InvalidRun("Failed to remove sanlock groups.")
Line 646:
Line 647: def isconfigured(self):
--
To view, visit
http://gerrit.ovirt.org/26055
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes