Nir Soffer has posted comments on this change.
Change subject: py3 tests: ported imagetickets_test.py to python3
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/59859/2/vdsm/storage/imagetickets.py
File vdsm/storage/imagetickets.py:
Line 26
Line 27
Line 28
Line 29
Line 30
This module is not available yet on python3, so this module cannot work on python 3.
The tests pass since they monkeypatch the missing uhttp. So we can have this test in
python3, but the actual coe will always fail with ImageDaemonUnsupported, not very
useful.
Better to keep the tests blacklisted so we remember that this does not work yet.
--
To view, visit
https://gerrit.ovirt.org/59859
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If13fb30966d98fa0381da25f0f2907899df12e96
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes