John Taylor has posted comments on this change.
Change subject: vdsm: Fix memory leak in netlink.py
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/39372/1/lib/vdsm/netlink.py
File lib/vdsm/netlink.py:
Line 63: link_get_by_name
based only on cursory review of the libnl docs, it seems that this
function
the _rtnl_link_put on line 68 is the call that will decrement the refcount,
allowing the later call to _nl_cache_free(cache), done in the _cache_manager
@contextmanager finally block, to be able to free the links in the cache. It might make
more sense to do it like in master
https://gerrit.ovirt.org/#/c/39416/ where it is
immediately following the call to get the link.
--
To view, visit
https://gerrit.ovirt.org/39372
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e4dc72bd77e46ba4f95dd8a622f5c3288115315
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: John Taylor <jtt77777(a)yahoo.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: John Taylor <jtt77777(a)yahoo.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes