Nir Soffer has posted comments on this change.
Change subject: vm: per-attribute monitor response check
......................................................................
Patch Set 1:
I don't understand what the original code is trying to do, and not what you are trying
to do. It would be nice if you explain this in the commit message better.
I also don't see the connection to
http://gerrit.ovirt.org/22575. The purpose of this
patch is to make sampling more reliable by logging errors and continuing sampling after
errors. For example, if you have multiple disks and the first disk sample fails, none of
the disks will be sampled in the current code.
--
To view, visit
http://gerrit.ovirt.org/23138
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32a98d34cde91fa9dc3d07f03c47a5f2f22da620
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No