Nir Soffer has posted comments on this change.
Change subject: tests: v2v: add test for commit f8127d8
......................................................................
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/47367/4/tests/v2vTests.py
File tests/v2vTests.py:
Line 266: self.assertEquals(len(vms), 1)
Line 267: self._assertVmMatchesSpec(vms[0], self._VM_SPECS[0],
Line 268: expect_disks=False)
Line 269:
Line 270: def _assertVmMatchesSpec(self, vm, spec, expect_disks=True):
Do we really need expect_disks?
Line 271: self.assertEquals(vm['vmId'], spec.vmid)
Line 272: self.assertEquals(vm['memSize'], 2048)
Line 273: self.assertEquals(vm['smp'], 1)
Line 274: self.assertEquals(len(vm['disks']), 1)
Line 282: self.assertIn('capacity', disk)
Line 283: self.assertIn('allocation', disk)
Line 284: else:
Line 285: self.assertNotIn('capacity', disk)
Line 286: self.assertNotIn('allocation', disk)
Why not check this in the test that want to test the disks separately?
Line 287:
Line 288: network = vm['networks'][0]
Line 289: self.assertEquals(network['type'], 'bridge')
Line 290: self.assertEquals(network['macAddr'],
_mac_from_uuid(spec.vmid))
--
To view, visit
https://gerrit.ovirt.org/47367
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38bd3c06df263bc208e1a8c8aa6c0081ebdc218d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes