Adam Litke has posted comments on this change.
Change subject: (Schema) Replace IntStr with proper integer types
......................................................................
Patch Set 1:
Hmm, I am conflicted here. I definitely agree that we need to differentiate between
signed and unsigned ints but I am not so sure about supporting all of the explicit sizes.
The acceptable ranges for some of these fields do conform exactly to the set of 32bit
numbers but for many of them the range is further restricted.
I wonder if it makes more sense to have only: int and uint where both are 64bits in size.
We need to write field validation anyway so the exact ranges can be encoded in the
annotations (comment block) and those ranges can be automatically enforced by an integer
range validator function on the server side.
--
To view, visit
http://gerrit.ovirt.org/6841
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I147c1ec2743ce3d4758103415f201370441b6e22
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>