Ido Barkan has posted comments on this change.
Change subject: net: tests: test_rollback
......................................................................
Patch Set 6: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/46875/6//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2015-10-09 10:31:16 +0200
Line 6:
Line 7: net: tests: test_rollback
Line 8:
Line 9: A simple rollback test. Created mainly for OVS testing.
This test is important in general. not just OVS.
Line 10:
Line 11: Change-Id: I71bc067c5f9f828a0a8899005be51c3695d81c20
https://gerrit.ovirt.org/#/c/46875/6/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 2777: self.assertBondDoesntExist(BONDING_NAME, nics)
Line 2778:
Line 2779: @cleanupNet
Line 2780: @ValidateRunningAsRoot
Line 2781: def test_rollback(self):
what? didn't we have already this trivial test? Oops.
Line 2782: with dummyIf(3) as nics:
Line 2783: NET1 = NETWORK_NAME + '1'
Line 2784: NET2 = NETWORK_NAME + '2'
Line 2785:
Line 2791: self.assertEqual(status, SUCCESS, msg)
Line 2792: self.assertNetworkExists(NET1)
Line 2793: self.assertBondExists(BONDING_NAME, nics[:2])
Line 2794:
Line 2795: # setup network with invalid IP, expecting failture
failure
Line 2796: status, msg = self.setupNetworks(
Line 2797: {NET2:
Line 2798: {'nic': nics[2], 'bridged': True,
'vlan': VLAN_ID,
Line 2799: 'netmask': '300.300.300.300',
'ipaddr': '300.300.300.300'}},
--
To view, visit
https://gerrit.ovirt.org/46875
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71bc067c5f9f828a0a8899005be51c3695d81c20
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes