ShaoHe Feng has posted comments on this change.
Change subject: dump the core of a VM
......................................................................
Patch Set 10: (3 inline comments)
....................................................
File vdsm/vm.py
Line 357: try:
Line 358: self.log.debug("begin to perform core dump")
Line 359: if self._vm._dom is None:
Line 360: raise RuntimeError('noVM')
Line 361: self._setupDumpParams()
see line 432.
It make no sense to call dumpParams in the __init__ when we instance a DoCoreDumpThread
class without kwargs.
Line 362: self.status = self._status(msg="ongoing")
Line 363: self._startUnderlyingDump()
Line 364: self.status = self._status(msg="finished")
Line 365: except libvirt.libvirtError, e:
Line 1335: # we do not care "Down"
Line 1336: self._doCoredumpThread = self.DoCoreDumpThreadClass(self, to,
Line 1337: **params)
Line 1338: self._doCoredumpThread.start()
Line 1339: check = self._doCoredumpThread.getStat()
about status or check, I have no prefer. same with line 1289
I have changed it to status.
about the move this call into the finally block.
I have tried. But not successfully.
same with 1294 or 1315
Line 1340: return check
Line 1341: except Exception, e:
Line 1342: self.log.exception("Failed to perform core dump. " +
e.message,
Line 1343: exc_info=True)
Line 1336: self._doCoredumpThread = self.DoCoreDumpThreadClass(self, to,
Line 1337: **params)
Line 1338: self._doCoredumpThread.start()
Line 1339: check = self._doCoredumpThread.getStat()
Line 1340: return check
I have tried, it can cause exception.
How did you try?
same with line 1315
Line 1341: except Exception, e:
Line 1342: self.log.exception("Failed to perform core dump. " +
e.message,
Line 1343: exc_info=True)
Line 1344: check = self._doCoredumpThread.getStat()
--
To view, visit
http://gerrit.ovirt.org/7329
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server