Ayal Baron has posted comments on this change.
Change subject: Avoid hsm image deletions.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/fileSD.py
Line 512: self.log.debug("Unmounting stale file system %s",
Line 513: self.mountpoint)
Line 514: mount.getMountFromTarget(self.mountpoint).umount()
Line 515: raise se.FileStorageDomainStaleNFSHandle()
Line 516: raise
I agree that this method is being called from the wrong place, I don't agree that it
should be removed.
It should be called when SPM starts to make sure to clean up garbage.
Line 517:
Line 518: def templateRelink(self, imgUUID, volUUID):
Line 519: """
Line 520: Relink all hardlinks of the template 'volUUID' in all VMs based
on it.
--
To view, visit
http://gerrit.ovirt.org/17193
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ec2ea8793a4ad63453559bc5f663b65f9b9336
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server