From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: configurators: move configurator functions into conf_utils
......................................................................
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/44286/4//COMMIT_MSG
Commit Message:
PS4, Line 7: configurators
please provide more details
it only moves code to make it
public
https://gerrit.ovirt.org/#/c/44286/4/lib/vdsm/tool/conf_utils.py
File lib/vdsm/tool/conf_utils.py:
Line 21: import os
Line 22:
Line 23: from vdsm.tool.configfile import ConfigFile
Line 24:
Line 25:
please add some explanation on how conf files are represented -
it's hard t
I don't make a util here.. this should be done separately maybe.
this patch is about moving code so I'll be able to use it in following patch
Line 26: def get_file(fname, files):
Line 27: return files[fname]['path']
Line 28:
Line 29:
--
To view, visit
https://gerrit.ovirt.org/44286
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id67a0f51adb2d543c0542a48c020d34a13d1f2ed
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes