Francesco Romani has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
......................................................................
Patch Set 8:
(2 comments)
http://gerrit.ovirt.org/#/c/19389/8/vdsm/API.py
File vdsm/API.py:
Line 379: def hibernate(self, target):
Line 380: """
Line 381: Hibernate a VM.
Line 382:
Line 383: :param mode: mem/disk/hybrid/hiberVolHandle
typo: target, not mode (either fix the docstring or the parameter naming)
Line 384: """
Line 385: if target in ('disk', 'mem', 'hybrid'):
Line 386: try:
Line 387: v = self._cif.vmContainer[self._UUID]
http://gerrit.ovirt.org/#/c/19389/8/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 5970: #
Line 5971: # Since: 4.12.0
Line 5972: ##
Line 5973: {'command': {'class': 'VM', 'name':
'hibernate'},
Line 5974: 'data': {'vmID': 'UUID', 'target':
'hibernationTarget'}}
Maybe I miss something, but this doesn't look backward compatible.
Line 5975:
Line 5976: ##
Line 5977: # @vmUpdateDeviceParams:
Line 5978: #
--
To view, visit
http://gerrit.ovirt.org/19389
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes