From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: introduce pylint check
......................................................................
Patch Set 12: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/69345/12/pylintrc
File pylintrc:
Line 166:
Line 167: [BASIC]
Line 168:
Line 169: # Required attributes for module, separated by a comma
Line 170: required-attributes=
This option u'required-attributes' will be removed in Pylint 2.0
Can we drop it?
Line 171:
Line 172: # List of builtins function names that should not be used, separated by a comma
Line 173: bad-functions=map,filter,input
Line 174:
Line 339: [CLASSES]
Line 340:
Line 341: # List of interface methods to ignore, separated by a comma. This is used for
Line 342: # instance to not check methods defines in Zope's Interface base class.
Line 343:
ignore-iface-methods=isImplementedBy,deferred,extends,names,namesAndDescriptions,queryDescriptionFor,getBases,getDescriptionFor,getDoc,getName,getTaggedValue,getTaggedValueTags,isEqualOrExtendedBy,setTaggedValue,isImplementedByInstancesOf,adaptWith,is_implemented_by
This option u'ignore-iface-methods' will be removed in Pylint 2.0
Can we avoid these warnings by dropping this line?
Line 344:
Line 345: # List of method names used to declare (i.e. assign) instance attributes.
Line 346: defining-attr-methods=__init__,__new__,setUp
Line 347:
https://gerrit.ovirt.org/#/c/69345/12/tox.ini
File tox.ini:
PS12, Line 39: lib/vdsm/
I *think* that you do not need to list this, since you already have "vdsm", and
"lib" is in your PYTHONPATH.
My comment referred to to our remaining vdsm/API.py vdsm/clientIF.py vdsm/hooking.py
vdsm/sitecustomize.py vdsm/vdsmd.py
I think that without adding vdsm/*.py you are not testing them.
--
To view, visit
https://gerrit.ovirt.org/69345
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85eca67784f82876b262b4452506e0f47486695b
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes